Fixed resolved discussions not toggling expanded on changes tab
What does this MR do?
This fixes a reactivity issue where the discussion would get replaced with a new object thus removing all references to that object. This means that when the object is updated, other places will not get the update therefore breaking the expansion of discussions.
Note This only happens when trying to expand & then collapse a resolved discussion on the changes tab. This is because when a collapsed discussion is expanded we fetch the diff lines, call the mutation SET_DISCUSSION_DIFF_LINES
which then removes the references.
This was caused by a change in %11.3 that meant each discussion is set by reference on the diff lines object rather than fetched and setup at render time.
What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/51370
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides
Edited by Mike Greiling