Skip to content

Update code_review.md to include a recommendation for assigning maintainers from different teams

Luke Bennett requested to merge code_review-assign-maintainers-different-team into master

What does this MR do?

Recommends that we assign maintainers from different teams to avoid team silos.

https://gitlab.slack.com/archives/CBFCUM0RX/p1536579424000100

I was thinking about this at the summit, and I think we should treat maintainers as a group totally separate from teams. Even if a team has a maintainer, I’d prefer for MRs to be reviewed by maintainers from other teams, so that we ensure that code looks the same across the board, and that code remains understandable to everyone, including people in other teams, and outside contributors. If code is written by people with a full understanding of the feature and existing code, and reviewed by people with a full understanding of the feature and existing code, that makes it easier for code to slip in that is actually hard to understand to anyone outside of the silo. Teams may also develop their own code styles and patterns, which we should avoid.

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

Merge request reports