Skip to content

Guarantee visually correct order of runners on the "Admin Area > Runners" page

Alexander Kutelev requested to merge (removed):contacted_at into master

What does this MR do?

Fixes visually incorrect order of runners on the "Admin Area > Runners" page when sorting by the "Last contact" column is enabled (fixes #49791 (closed)).

After some time point I observe strange values in the "Last contact" column an the Runners Admin page. Even when sorting is enabled values there are not in order.

Looks like sorting is done using contacted_at which are in the DB but cached values are displayed then. Cached values differ a lot from values which are in the DB, as result there is inconsistent data shown on the "Admin Area > Runners" page.

With this change "Last contact" column contains descending numbers (as expected).

image

What are the relevant issue numbers?

#49791 (closed)

Does this MR meet the acceptance criteria?

Edited by Alexander Kutelev

Merge request reports