Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
GitLab FOSS
GitLab FOSS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 0
    • Merge Requests 0
  • Requirements
    • Requirements
    • List
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge Requests
  • !21598

You need to sign in or sign up before continuing.
Merged
Opened Sep 07, 2018 by Nick Thomas@nick.thomas🏖Maintainer7 of 7 tasks completed7/7 tasks

Resolve "Add functionality to change what email address online actions commit using"

  • Overview 22
  • Commits 19
  • Pipelines 8
  • Changes 13

What does this MR do?

Follow-up to https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21213/diffs#note_99488777 that fixes a small issue with the list of displayed commit emails, bearing https://gitlab.com/gitlab-org/gitlab-ce/issues/51235 in mind.

We should only allow verified emails that are not the primary address to be explicitly selected.

This shows additional commits because !21213 (closed) isn't merged yet. In practice, only 43a9b530 is unreviewed.

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • Tests added for this feature/bug
  • Conforms to the code review guidelines
  • Conforms to the merge request performance guidelines
  • Conforms to the style guides
  • Conforms to the database guides

Closes #23986 (closed)

Edited Sep 07, 2018 by Nick Thomas
Assignee
Assign to
Reviewer
Request review from
11.4
Milestone
11.4 (Past due)
Assign milestone
Time tracking
Reference: gitlab-org/gitlab-foss!21598
Source branch: 23986-choose-commit-email