Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !21598
The source project of this merge request has been removed.

Resolve "Add functionality to change what email address online actions commit using"

Merged Nick Thomas requested to merge (removed):23986-choose-commit-email into master Sep 07, 2018
  • Overview 22
  • Pipelines 0
  • Changes 13

What does this MR do?

Follow-up to https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21213/diffs#note_99488777 that fixes a small issue with the list of displayed commit emails, bearing https://gitlab.com/gitlab-org/gitlab-ce/issues/51235 in mind.

We should only allow verified emails that are not the primary address to be explicitly selected.

This shows additional commits because !21213 (closed) isn't merged yet. In practice, only 43a9b530 is unreviewed.

What are the relevant issue numbers?

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • Tests added for this feature/bug
  • Conforms to the code review guidelines
  • Conforms to the merge request performance guidelines
  • Conforms to the style guides
  • Conforms to the database guides

Closes #23986 (closed)

Edited Sep 07, 2018 by Nick Thomas
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 23986-choose-commit-email