Resolve "Project deletion may not log audit events during group deletion"
requested to merge 49796-project-deletion-may-not-log-audit-events-during-group-deletion into master
What does this MR do?
Currently, we don't check if a repository was successfully deleted when we delete a group. As a result when it fails we delete it anyway but with no Audit Event and Geo event. The approach implemented here adds the missing check and raise an error. As we always run Groups::DestroyService
in a background the sidekiq job will be retried in case of error.
What are the relevant issue numbers?
https://gitlab.com/gitlab-org/gitlab-ce/issues/49796
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides
Closes #49796 (closed)
Edited by Valery Sizov