Skip to content

Fix missing and duplicates on project milestone listing page

What does this MR do?

Sorts by Milestone id DESC, along with the existing ordering on project's milestone list page.

Are there points in the code the reviewer needs to double check?

This ~bug may be hidden in other places that overrides / implements sort_by_attribute, if the AR relation (caller) doesn't include a unique ID ordering in place.

Maybe we could have a follow up issue for Quality test with a more generic test for paginated collections, ensuring we have no missing or duplicates.

Why was this MR needed?

https://gitlab.com/gitlab-org/gitlab-ce/issues/37078

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/37078

Edited by Oswaldo Ferreira

Merge request reports