Skip to content

Improve blocked user tracking and fire some events only once

Grzegorz Bizon requested to merge fix/gb/improve-blocked-user-tracking into master

What does this MR do?

  • Do not fire warden events twice when user is not fully authenticated
  • Do not use BlockerUserTracker to track blocked users since we can use before_logout for this.

Are there points in the code the reviewer needs to double check?

Is that okay to use warden.authenticated?(:user) in the use case in the application controller?

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes gitlab-org/gitlab-ce#49784

Edited by Grzegorz Bizon

Merge request reports