Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab FOSS GitLab FOSS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 0
    • Merge requests 0
  • Requirements
    • Requirements
    • List
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !20918

Merged
Created Jul 31, 2018 by Jarka Košanová@jarka👶Maintainer8 of 14 tasks completed8/14 tasks

Rake task for checking orphaned object store uploads

  • Overview 52
  • Commits 1
  • Pipelines 8
  • Changes 5

What does this MR do?

It searches through all remote uploads and lists/removes all files that are in the storage but not in uploads table

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

There was an issue (https://gitlab.com/gitlab-org/gitlab-ce/issues/45425) which caused that object store uploads were not deleted when deleting its parent resource. We need to remove the files that were not removed.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests added for this feature/bug
  • Conforms to the code review guidelines
    • Has been reviewed by a UX Designer
    • Has been reviewed by a Frontend maintainer
    • Has been reviewed by a Backend maintainer
    • Has been reviewed by a Database specialist
  • Conforms to the merge request performance guidelines
  • Conforms to the style guides
  • Conforms to the database guides
  • If you have multiple commits, please combine them into a few logically organized commits by squashing them
  • Internationalization required/considered
  • End-to-end tests pass (package-and-qa manual pipeline job)

What are the relevant issue numbers?

Closes #46535 (closed)

Edited Aug 07, 2018 by Kamil Trzciński
Assignee
Assign to
Reviewer
Request review from
11.2
Milestone
11.2 (Past due)
Assign milestone
Time tracking
Source branch: 46535-orphaned-uploads