Skip to content

Permit concurrent loads in gpg keychain mutex

What does this MR do?

Wrap MUTEX.synchronize in lib/gitlab/gpg.rb in a permit_concurrent_loads for Rails 5. This fixes new timeouts in the Rails 5 specs: https://gitlab.com/gitlab-org/gitlab-ce/pipelines/26708054/failures

The fix is similar to !20473 (merged) and I think it is now needed because !20524 (merged) is merged and this code is now called more often.

Can be reproduced locally by running: RAILS5=1 bin/rspec spec/features/issues/filtered_search/filter_issues_spec.rb:84 spec/features/projects/files/user_replaces_files_spec.rb:26

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

rails5 upgrade

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Edited by Grzegorz Bizon

Merge request reports