Skip to content

Improve search bar: typing state

What does this MR do?

[Examples for all the possible row types can be found here]

  • The max height of the suggestion dropdown should be 400px
  • There should be a fade effect layer at the bottom to indicate the dropdown is scrollable.
  • All substrings inside the dropdown which match the query should be bolded.
  • The first row should be automatically highlighted, so the user can just press Enter to search.
  • The first rows in the dropdown should allow the user to perform a search for the entered term:
    • Search rows for project scope:
    • Row 1: Magnifying glass + "KEYWORD" in this project
    • Row 2: Magnifying glass + "KEYWORD" in all GitLab
    • Search rows for group scope:
    • Row 1: Magnifying glass + "KEYWORD" in this group
    • Row 2: Magnifying glass + "KEYWORD" in all GitLab
    • Search row for global scope:
    • Row 1: Magnifying glass + "KEYWORD" in all GitLab

After that, navigation suggestions will be shown for projects, groups, pages inside the project/group, preferences pages and help pages that match the string entered.

  • Project and group rows will show their avatar on the left side.
    • The size of the avatar will be 16px x 16px
    • The margin between the avatar and the name will be 4px
    • If the project or group doesn't have an avatar, the generic one with its initial should be used.
  • The headers for each type of suggestion should also be updated to match the spec previews
  • The header for pages in the project or group should be renamed to:
    • Project: In this project
    • Group: In this group

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

See #36409 (closed)

Screenshots (if relevant)

null

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #36409 (closed)

Edited by Dennis Tang

Merge request reports