Improve search bar: resting state
What does this MR do?
Resting state:
- Increase the width of the search box to
240px
- Remove the scope indicator (
This group
andThis project
). - Rephrase the placeholder to: “Search or jump to…”
Are there points in the code the reviewer needs to double check?
That I didn't terribly break something by changing the gitlab-theme
mixin or the search template.
Why was this MR needed?
See #36409 (closed)
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
- Conforms to the code review guidelines
-
Has been reviewed by a Frontend maintainer
-
-
Conforms to the merge request performance guidelines -
Conforms to the style guides -
If you have multiple commits, please combine them into a few logically organized commits by squashing them -
Internationalization required/considered -
End-to-end tests pass ( package-and-qa
manual pipeline job)
What are the relevant issue numbers?
Closes #36409 (closed)
Merge request reports
Activity
mentioned in merge request !20537 (merged)
2 Warnings Most of the time, all merge requests should target master
. Otherwise, please set the relevantPick into X.Y
label.CHANGELOG missing. You can create one with:
bin/changelog -m 20882 "WIP: Improve search bar: resting state"
If your merge request doesn’t warrant a CHANGELOG entry,
consider adding any of the ~backstage, ~Documentation, QA, test labels.
See the documentation.Generated by
DangerEdited by 🤖 GitLab Bot 🤖added Deliverable ~2278658 ~6575249 frontend navigation labels
changed milestone to %11.2
assigned to @dennis
added 8 commits
- 8e9c7877 - tooltip_message is frozen so dup it before sanitizing
- 7553046b - Update CHANGELOG.md for 11.1.3
- 35ce06ad - Merge branch '49681-dup-before-sanitize' into 'master'
- cef41153 - Fix Karma failures due to invalid icon names
- 87f03f01 - Merge branch 'sh-fix-karma-failures-icons' into 'master'
- 7ecd3608 - remove location badge from search autocomplete
- 2665c26e - update search autocomplete placeholder and aria label
- 3b183053 - update search input width from 220px to 240px
Toggle commit listadded 2 commits
assigned to @lbennett
Looks so much cleaner @dennis!
The theme mixin changes looked a little intimidating but they seem to be perfectly fine, either way, I suggest picking one of our CSS aficionadi for maintainer review for each of these MRs.assigned to @dennis
marked the checklist item Internationalization required/considered as completed
marked the checklist item If you have multiple commits, please combine them into a few logically organized commits by squashing them as completed
Hi @annabeldunstone! Can you review this one? This is going into a feature branch at which point UX will review it.
assigned to @annabeldunstone
@dennis is this MR (and all the others) ready to be merged into the feature branch?
@dennis is this MR (and all the others) ready to be merged into the feature branch?
@annabeldunstone yup! If the other MRs look good to you then we can merge all these into the feature branch.
mentioned in commit fc4dbd9d