Skip to content

Fix: redirect non-SSL request for gitlab registry to valid URL

What does this MR do?

Fixes a bug in nginx ssl configuration for gitlab runner. Redirect URLs contained a colon between host and path.

Are there points in the code the reviewer needs to double check?

Unifies the configuration with gitlab-ssl (https://gitlab.com/gitlab-org/gitlab-ce/blob/23f705f2d0f10ed765929afa923ee096d9f0e136/lib/support/nginx/gitlab-ssl#L79) and gitlab-pages-ssl (https://gitlab.com/gitlab-org/gitlab-ce/blob/23f705f2d0f10ed765929afa923ee096d9f0e136/lib/support/nginx/gitlab-pages-ssl#L17).

Why was this MR needed?

The invalid redirect URLs cause an error for Let's encrypt cert request validation. Therefore using webroot plugin of certbot is not possible.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

#43664 (moved)

Edited by jelhan

Merge request reports