Skip to content

Fix serialization of LegacyDiffNote

Jan Provaznik requested to merge jprovazn-fix-diff-note into master

What does this MR do?

It checks if note's class is DiffNote (rather than using #diff_note? method which is true both for DiffNote and `LegacyDiffNote).

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

LegacyDiffNote may have position set to empty string (instead of nil) which causes that .to_h raises an exception.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #49355 (closed)

Edited by Jan Provaznik

Merge request reports