Skip to content

Avoid building potential invalid environment name while seeding

Lin Jen-Shin requested to merge make-sure-env-name-not-ending-in-slash into master

What does this MR do?

Avoid building potential invalid environment name while seeding

Why was this MR needed?

Make sure we're matching the same way.

Ruby's regular expression is unicode aware, therefore 'å' also matches against /\p{alnum}/+. If we want only ASCII-7bit, use /[a-zA-Z0-9]+/ so they always match the same thing.

Does this MR meet the acceptance criteria?

  • Tests added for this feature/bug
  • Conform by the code review guidelines
    • Has been reviewed by a Backend maintainer

What are the relevant issue numbers?

~"broken master" https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/80673766

Edited by Nick Thomas

Merge request reports