Add `NOT NULL` constraints to `file_store` columns
requested to merge cleanup-fill-file-store-background-migrations-with-not-null-constraint into cleanup-fill-file-store-background-migrations
What does this MR do?
This MR adds NOT NULL
constraints to each file_store
/store
columns in ci_job_artifacts
, lfs_objects
and uploads
tables.
The tricky part is the NOT NULL
validation is performed before the application sets the value. We need to re-organize update_file_store
before we add the constraints. Historically speaking, this is not easy change as we're being suffered with CarrieWave for a long time.
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Conform by the code review guidelines
-
Has been reviewed by a Backend maintainer -
Has been reviewed by a Database specialist
-
-
End-to-end tests pass ( package-and-qa
manual pipeline job)
What are the relevant issue numbers?
Edited by Shinya Maeda