Skip to content

Close revert and cherry pick modal on escape keypress

What does this MR do?

Closes revert and cherry pick modal on escape keypress.

Are there points in the code the reviewer needs to double check?

Check if tabindex in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20341/diffs#412a13700afb72e214e737f38973af17fda5ce5c_15_14 uses the best possible value.

Screenshots (if relevant)

Revert modal Cherry-pick modal
modal-revert modal-cherry-pick

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Tests added for this feature/bug
  • Conform by the code review guidelines
    • Has been reviewed by a UX Designer
    • Has been reviewed by a Frontend maintainer

What are the relevant issue numbers?

#45850 (closed). Following the work done in !19050 (merged). Thanks @jacopo-beschi!

Edited by Jeethu Karthik

Merge request reports