#39604 - Change top-right avatar immediately upon avatar change
First attempt at contributing to GitLab! I've set this as WIP because I feel like I should write a test, but I'm not too sure what kind of test and where you'd want it. A little pointer would be great.
I wasn't sure if I should check items off on the acceptance criteria, as it feels more like something a reviewer should do.
What does this MR do?
After a user successfully changes their avatar, this MR will ensure that the little avatar in the header is updated as well. Previously, this required a page reload.
Are there points in the code the reviewer needs to double check?
- Check if my use of jQuery is acceptable here
- Let me know if a test is required for this, and if so, what kind of test is preferred? It's a very tiny change, but totally testable if I'm aware what kind of test it needs to be.
Why was this MR needed?
Because there's an issue, which is labelled ~"Accepting Merge Requests" and ~"Community Contribution". Current behaviour feels a little unpolished.
Screenshots (if relevant)
I'd leave a gif or something, but I'm currently not on a machine with an easy way of doing this. A screenshot wouldn't show anything different.
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Conform by the code review guidelines
-
Has been reviewed by a UX Designer -
Has been reviewed by a Frontend maintainer -
Has been reviewed by a Backend maintainer -
Has been reviewed by a Database specialist
-
-
Conform by the merge request performance guides -
Conform by the style guides -
If you have multiple commits, please combine them into a few logically organized commits by squashing them -
Internationalization required/considered -
End-to-end tests pass ( package-and-qa
manual pipeline job)
What are the relevant issue numbers?
Closes #39604 (closed)