Skip to content

Make GFM Autocomplete configurable

Kushal Pandya requested to merge kp-make-gfm-autocomplete-configurable into master

What does this MR do?

This MR does changes to GLForm class such that GFM autocomplete is configurable where individual keywords can be enabled/disabled selectively.

Why was this MR needed?

Current setup of GLForm has hard-coded config for all supported autocomplete keywords where it was not possible to enable/disable certain keywords so it was "all or none" affair. In Epics, only some of the keywords are supported so changes in this MR would allow to disable listeners for unsupported keywords in Epics in EE.

Does this MR meet the acceptance criteria?

  • [ ] Changelog entry added, if necessary
  • [ ] Documentation created/updated
  • API support added
  • [ ] Tests added for this feature/bug
  • Conform by the code review guidelines
    • [ ] Has been reviewed by a UX Designer
    • Has been reviewed by a Frontend maintainer
    • Has been reviewed by a Backend maintainer
    • [ ] Has been reviewed by a Database specialist
  • Conform by the merge request performance guides
  • Conform by the style guides
  • If you have multiple commits, please combine them into a few logically organized commits by squashing them
  • Internationalization required/considered
  • End-to-end tests pass (package-and-qa manual pipeline job)

What are the relevant issue numbers?

https://gitlab.com/gitlab-org/gitlab-ee/issues/5605

Edited by Phil Hughes

Merge request reports