Skip to content

Disallow methods that copy data on large tables

Sean McGivern requested to merge update-large-tables-cop into master

What does this MR do?

Add {change_column_type,rename_column}_concurrently to the list of methods forbidden on large tables.

Are there points in the code the reviewer needs to double check?

According to gitlab-com/database#95 (closed), this may not be needed for users? I can split the tables into two categories if that's true, but I thought it was best to be conservative.

Why was this MR needed?

See https://gitlab.com/gitlab-org/gitlab-ce/issues/47566. Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/47591.

Merge request reports