Skip to content

PUT MergeRequest API endpoint - accept labels as an array

Mario de la Ossa requested to merge api-mr-put-labels into master

What does this MR do?

Accepts labels sent as an array ['bug', 'feature freeze'] as well as the usual comma-separated string ("bug, feature freeze") in the PUT MergeRequests API endpoint.

Despite this addition I believe documentation should not be added declaring we support this. Instead this should be a "principle of least surprise" addition (since we also have some other endpoints in which we expect comma-separated strings and don't support arrays and we should update those as well if this gets added)

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

It seems like a point of confusion that we have to send what a developer would usually think of as an array in a comma-separated list

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Edited by 🤖 GitLab Bot 🤖

Merge request reports