Skip to content

Rails5 fix db check: connection execute returns integer instead of string

Jasper Maes requested to merge jlemaes/gitlab-ce:rails5-fix-db-check into master

What does this MR do?

In Rails 5 the check returns 1 instead of '1'. A simple &.to_s fixes the problem.

Fixes these specs:

rspec ./spec/controllers/health_controller_spec.rb[1:2:1:1:1]
rspec ./spec/controllers/health_controller_spec.rb[1:2:2:2:1:1:1]
rspec ./spec/controllers/health_controller_spec.rb[1:2:2:3:1:1]
rspec ./spec/lib/gitlab/health_checks/db_check_spec.rb[1:3:1]

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

rails5 upgrade

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Edited by Yorick Peterse

Merge request reports