Skip to content

[Rails5] Fix optimistic lock value

blackst0ne requested to merge blackst0ne-rails5-fix-optimistic-lock-values into master

What does this MR do?

Updates the monkey-patch to make it work in Rails 5.

Fixes the error:

Failures:

  1) IssueSerializer non-sidebar issue serialization matches issue json schema
     Failure/Error: JSON::Validator.validate!(SchemaPath.expand(schema, dir), data, options)

     JSON::Schema::ValidationError:
       The property '#/lock_version' of type integer did not match one or more of the following types: string, null
     # ./spec/support/api/schema_matcher.rb:23:in `block (2 levels) in <top (required)>'
     # ./spec/serializers/issue_serializer_spec.rb:16:in `block (3 levels) in <top (required)>'

Finished in 9 minutes 4 seconds (files took 17.56 seconds to load)
1572 examples, 1 failure, 1 pending

Are there points in the code the reviewer needs to double check?

Do we really want to use NULL instead of 0?

Why was this MR needed?

Migration to Rails 5.0.

Screenshots (if relevant)

No.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #47961 (closed)

Edited by Yorick Peterse

Merge request reports