Resolve "Tab active state is not changing correctly on new merge request page" (!19781) · Merge requests · GitLab.org / GitLab FOSS

Jan Beckmann requested to merge kingjan1999/gitlab-ce:47871-new-mr-tab-active-state into master Jun 13, 2018

What does this MR do?

Removes the default .active of the commits-pane on the new merge request page. This caused the tab to remain highlighted even when it was deselected (see relevant issue and/or video below).

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Before: merge-requests-old-nosound

After: merge-requests-new-nosound

(Sorry for the bad quality)

Does this MR meet the acceptance criteria?

Changelog entry added, if necessary
Conform by the code review guidelines
- Has been reviewed by a Frontend maintainer
Conform by the merge request performance guides
Conform by the style guides
If you have multiple commits, please combine them into a few logically organized commits by squashing them

What are the relevant issue numbers?

Closes #47871 (closed)

Resolve "Tab active state is not changing correctly on new merge request page"