Skip to content

Resolve "Selections are not shown in the review mode diff"

What does this MR do?

Gives the Web IDE diff line highlights some opacity to allow the text selection overlay to be seen.

Are there points in the code the reviewer needs to double check?

The highlight colors are somewhat lighter now, I kinda like the change but if it's a problem then I could darken them again.

Why was this MR needed?

For whatever reason, Monaco puts the red-or-green color overlays above of the text selection overlay instead of under it. The default styling uses colors with an opacity of 0.2 to allow the text selection overlay to be seen, but GitLab's stylesheet overrode this with fully-opaque colors, preventing the text selection overlay from being seen.

What are the relevant issue numbers?

#47771 (closed)

Merge request reports