Skip to content

Users can accept terms during registration

Bob Van Landuyt requested to merge bvl-terms-on-registration into master

What does this MR do?

This adds a checkbox to the registration form:

Screen_Shot_2018-06-08_at_14.02.09

The checkbox is shown when terms are enforced in the admin panel of the instance. The checkbox links to /-/users/terms which is now accessible to unauthenticated users. The link opens in a new tab so the users can close it and continue their registration.

This new checkbox is required when the terms are enforced for the installation. When the user checked the checkbox during registration, they will not be required to accept the terms again later.

When the terms page /-/users/terms is viewed by an unauthenticated user, the buttons to Accept, Decline or Continue are hidden. So is the profile menu at the top:

Screen_Shot_2018-06-08_at_14.08.10

Since the new checkbox mentions both ToS and Privacy Policy, the form in the admin area has been updated to reflect that:

Screen_Shot_2018-06-08_at_18.13.26

While I was there I added the missing fieldset-form-class.

Why was this MR needed?

Because the current registration form was not in compliance with GDPR: https://gitlab.com/gitlab-org/gitlab-ee/issues/6262

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/6262 Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/47621

EE-port in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/6060

Edited by Bob Van Landuyt

Merge request reports