Skip to content

Rails5 fix arel from

Jasper Maes requested to merge jlemaes/gitlab-ce:rails5-fix-46281 into master

What does this MR do?

Fixes arel 7 from usage. The function was changed in https://github.com/rails/arel/commit/98fc25991137ee09b6800578117f8c1c322680f2. With the rails5 changes the count produces the exact same sql.

Are there points in the code the reviewer needs to double check?

The same fix is probably needed in mysql_median_datetime_sql but I can't test that on Rails5

Why was this MR needed?

rails5 upgrade

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #46281 (closed)

Edited by Yorick Peterse

Merge request reports