Skip to content

Enable mapping to nil in enums

Jan Provaznik requested to merge rails5-enum-nil into master

What does this MR do?

Enum in Rails 5 does not map nil values - IOW nil value remains nil, even if there is a key with nil value in the enum definition.

This commit overrides the underlying Enum methods so nil value is still mapped. This solution is far from being ideal: it uses dynamic definition of methods which introduces more magic/confusion into the codebase.

It would be better to get rid of the nil value in enums (which will be addressed in a follow-up issue).

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #47032 (closed), #46279 (closed)

Edited by blackst0ne

Merge request reports