Skip to content

Replace `.exists` with `EXISTS ()`

Jan Provaznik requested to merge rails5-exists-query into master

What does this MR do?

It replaces .exists call with more explicit EXIST () - the generated sql query should be same in both cases.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

  • .exists is not part of public AR's API, it should not be used
  • there is a bug in early version of rails 5 which causes that limit() doesn't work in combination with exists - https://github.com/rails/rails/issues/16959

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #46277 (closed)

Edited by Yorick Peterse

Merge request reports