Resolve "Remove links from Web IDE unexpectedly navigate you to a different page"
requested to merge 45520-remove-links-from-web-ide-unexpectedly-navigate-you-to-a-different-page into master
What does this MR do?
This MR removes the blame, history, permailink, and download buttons from the web IDE. It replaces them with a single "Open in file view" button that takes you to the file view page in a new window.
Are there points in the code the reviewer needs to double check?
In the spec test for this, I've used a generic a
selector. It works but it doesn't sit right with me. But short of adding a class to the button just for the tests, I'm not sure what a better solution would be.
Why was this MR needed?
Because the aforementioned buttons would take you to a new page unexpectedly. This makes it a little more clear what will happen when you click the link.
See the related issue for more discussion.
Screenshots (if relevant)
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
API support added -
Tests added for this feature/bug - Conform by the code review guidelines
-
Has been reviewed by a UX Designer -
Has been reviewed by a Frontend maintainer -
Has been reviewed by a Backend maintainer -
Has been reviewed by a Database specialist
-
-
Conform by the merge request performance guides -
Conform by the style guides -
If you have multiple commits, please combine them into a few logically organized commits by squashing them -
Internationalization required/considered -
End-to-end tests pass ( package-and-qa
manual pipeline job)
What are the relevant issue numbers?
Closes #45520 (closed)
Edited by Dimitrie Hoekstra