Skip to content

Resolve "Remove links from Web IDE unexpectedly navigate you to a different page"

What does this MR do?

This MR removes the blame, history, permailink, and download buttons from the web IDE. It replaces them with a single "Open in file view" button that takes you to the file view page in a new window.

Are there points in the code the reviewer needs to double check?

In the spec test for this, I've used a generic a selector. It works but it doesn't sit right with me. But short of adding a class to the button just for the tests, I'm not sure what a better solution would be.

Why was this MR needed?

Because the aforementioned buttons would take you to a new page unexpectedly. This makes it a little more clear what will happen when you click the link.

See the related issue for more discussion.

Screenshots (if relevant)

localhost_3000_-ide_project_twitter_typeahead-js_blob_master-_.gitignore

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #45520 (closed)

Edited by Dimitrie Hoekstra

Merge request reports

Loading