Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar

Scheduled maintenance on the database layer will take place on 2022-07-02. We expect GitLab.com to be unavailable for up to 2 hours starting from 06:00 UTC. Kindly follow our status page for updates and read more in our blog post.

  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !19039
The source project of this merge request has been removed.

Resolve "Blob#batch can't handle frozen string paths"

Merged Nick Thomas requested to merge (removed):46498-do-not-modify-strings into master May 18, 2018
  • Overview 10
  • Changes 2

What does this MR do?

Fixes runtime errors related to modifying frozen strings

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Gitaly calls return frozen strings. Some rugged calls attempt to modify strings which are the outputs of gitaly calls, with some combinations of feature flags.

Modifying the string is unnecessary, and poor form anyway in a library method, so we can just switch to sub.

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

  • [-] Changelog entry added, if necessary
  • [-] Documentation created/updated
  • [-] API support added
  • [-] Tests added for this feature/bug
  • Conform by the code review guidelines
    • Has been reviewed by a Backend maintainer
  • Conform by the merge request performance guides
  • Conform by the style guides
  • If you have multiple commits, please combine them into a few logically organized commits by squashing them
  • Internationalization required/considered
  • End-to-end tests pass (package-and-qa manual pipeline job)

What are the relevant issue numbers?

Closes #46498 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 46498-do-not-modify-strings