Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !18989

Rescue Kubeclient::HttpError when generating prometheus_client

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Shinya Maeda requested to merge fix-kube_client-proxy_url-exception into master May 16, 2018
  • Overview 15
  • Commits 4
  • Pipelines 4
  • Changes 4

What does this MR do?

Currently users are unable to see environment pages if the clusters are improperly configured. This MR fixes the 500 error.

  • Sentry: https://sentry.gitlap.com/gitlab/gitlabcom/issues/192832/
  • ZD: https://gitlab.zendesk.com/agent/tickets/95412
  • Issue: https://gitlab.com/gitlab-org/gitlab-ce/issues/46406
  • Slack: https://gitlab.slack.com/archives/C0SFP840G/p1526132883000135

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

  • Tests added for this feature/bug
  • Conform by the code review guidelines
    • Has been reviewed by a Backend maintainer
  • End-to-end tests pass (package-and-qa manual pipeline job)

What are the relevant issue numbers?

Related: https://gitlab.com/gitlab-org/gitlab-ce/issues/46406

Edited May 21, 2018 by Grzegorz Bizon
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-kube_client-proxy_url-exception