Resolve "Include the human repo name in gitlab-shell.log when hashed storage is in use"
requested to merge 41229-include-the-human-repo-name-in-gitlab-shell-log-when-hashed-storage-is-in-use into master
What does this MR do?
This is a very minor MR that adds for project "<project.full_path>"
to the end of log lines that show a repo being deleted (via being moved to a new directory called <previous_dir>+deleted
).
Are there points in the code the reviewer needs to double check?
N/A
Why was this MR needed?
When looking at an individual Repository <repo_path> moved to <repo_path>+deleted
log line for projects that have hashed storage enabled, it's very difficult to determine the project name.
When hashed storage
Screenshots (if relevant)
Log output now (addition of for project "<project.full_path>"
):
Project with hashed storage enabled for repo:
May 10, 2018 16:13: Repository "@hashed/b1/7e/b17ef6d19c7a5b1ee83b907c595526dcb1eb06db8227d650d5dda0a9f4ce8cd9" moved to "@hashed/b1/7e/b17ef6d19c7a5b1ee83b907c595526dcb1eb06db8227d650d5dda0a9f4ce8cd9+16+deleted" for project "root/mop"
May 10, 2018 16:13: Repository "@hashed/b1/7e/b17ef6d19c7a5b1ee83b907c595526dcb1eb06db8227d650d5dda0a9f4ce8cd9.wiki" moved to "@hashed/b1/7e/b17ef6d19c7a5b1ee83b907c595526dcb1eb06db8227d650d5dda0a9f4ce8cd9.wiki+16+deleted" for project "root/mop"
May 10, 2018 16:13: Project "root/mop" was removed
Project without hashed storage enabled for repo:
May 10, 2018 16:14: Administrator created a new project "Administrator / clop"
May 10, 2018 16:14: Repository "root/clop" moved to "root/clop+18+deleted" for project "root/clop"
May 10, 2018 16:14: Repository "root/clop.wiki" moved to "root/clop.wiki+18+deleted" for project "root/clop"
May 10, 2018 16:14: Project "root/clop" was removed
Does this MR meet the acceptance criteria?
[ ] Changelog entry added, if necessary[ ] Documentation created/updated[ ] API support added[ ] Tests added for this feature/bug- Review
[ ] Has been reviewed by UX[ ] Has been reviewed by Frontend-
Has been reviewed by Backend [ ] Has been reviewed by Database
-
Conform by the merge request performance guides -
Conform by the style guides -
Squashed related commits together [ ] Internationalization required/considered-
End-to-end tests pass ( package-and-qa
manual pipeline job)
What are the relevant issue numbers?
Closes #41229 (closed)
Edited by Nick Thomas