NestingDepth (level 5) in pages/pipelines.scss
What does this MR do?
Reduces the number of SCSS selector depth from 6 to 5 by removing selectors.
Are there points in the code the reviewer needs to double check?
No.
Why was this MR needed?
Nesting 5 times in SCSS is too complicated.
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary - [n/a] Documentation created/updated
- [n/a] API support added
- [n/a] Tests added for this feature/bug
- Review
- [n/a] Has been reviewed by UX
-
Has been reviewed by Frontend - [n/a] Has been reviewed by Backend
- [n/a] Has been reviewed by Database
-
Conform by the merge request performance guides -
Conform by the style guides -
Squashed related commits together - [n/a] Internationalization required/considered
- [n/a] End-to-end tests pass (
package-and-qa
manual pipeline job)
What are the relevant issue numbers?
Part of #39584 (moved)
Similar to !17820 (merged)
Merge request reports
Activity
mentioned in issue #39584 (moved)
added 1 commit
- a0f18e58 - Apply NestingDepth (level 5) (pages/pipelines.scss)
marked the checklist item Squashed related commits together as completed
marked the checklist item Conform by the style guides as completed
marked the checklist item Conform by the merge request performance guides as completed
marked the checklist item Changelog entry added, if necessary as completed
added 168 commits
-
a0f18e58...40683268 - 167 commits from branch
gitlab-org:master
- abdaebc8 - Apply NestingDepth (level 5) (pages/pipelines.scss)
-
a0f18e58...40683268 - 167 commits from branch
assigned to @ClemMakesApps
@ClemMakesApps Could you review this? cf. !16275 (merged), !17820 (merged)
changed milestone to %11.0
@annabeldunstone can you review instead? Thanks
assigned to @annabeldunstone
LGTM! Thanks @tnir
mentioned in commit f5e0b35d
mentioned in issue gitlab#19977 (closed)