Skip to content

Add triage policies for bugs with no priority or severity

Mark Fletcher requested to merge markglenfletcher/gitlab-ce:highlight-no-priority-no-severity-bugs into gl-triage

According to the new labelling policies introduced, all bugs should have a label applied to indicate priority and severity:

The new triage policies introduced by this MR will filter bug issues per team and mention the product manager to gauge the priority and severity and apply a label.

Problems

1

Summary

There is no timeframe associated with the rule, therefore it can potentially apply to every issue in every run.

The problem with this is, we are adding a comment to mention the product managers and myself and this will happen on every run (currently run once per day)

Solution

( This is currently implemented in this MR )

Apply a label when mentioning the owners to exclude the issue from subsequent runs. In the case of priority, this is a no-priority label.

I was hesitant to add another label here, but I don't think it's such a problem as it allows us to filter on unprioritised issues after the first run.

We could even write a policy to clean up prioritized issues with no-priority labels still applied

2

Summary

Currently, the priority and severity policies are enforced as two different rule sets. This means that two mentions will be sent if the issue is currently without both priority and severity labels(?)

Solution

( This is not currently implemented in this MR )

Introduce one ruleset first (severity) and then clean up the missing priorities later by introducing the second ruleset (priority)

3

Summary

Who to mention here?

  • The product manager is currently marked to mention
  • I've marked myself to mention so that I can try to reproduce the bugs

Solution

  • Should the whole quality team be mentioned to share the load?
  • Should the technical team lead by mentioned to gauge severity
  • Or we lean on the product manager to pull that person in if necessary

Discussions

Merging lists in yml

I wanted to dry up the mention lists by creating references for the different teams to be merged together to form the full list of users to mention, but I'm not sure that this is possible in yaml.

Todos before merging

  • Create the no priority label at the gitlab-org group level
  • Create the no severity label at the gitlab-org group level

Related issues

Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/44862, https://gitlab.com/gitlab-org/gitlab-ce/issues/45490

Edited by Mark Fletcher

Merge request reports