Skip to content

Live trace: Rescue stale live trace

Shinya Maeda requested to merge live-trace-v2-persist-data into master

What does this MR do?

This MR was inspired by @ayufan 's following comment.

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/18554#note_70681896

I would think that we might need some cron job to be executed every sometime to flush old chunks to DB, as we might lose Sidekiq jobs for whatever reason.

Actually, instead of flushing we might just fire the archive! too. Maybe this is better.

So:

  1. If still running, but older than 1h, force flush to db,
  2. If finished, force archive!.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by Database
    • Has been reviewed by Backend
  • End-to-end tests pass (package-and-qa manual pipeline job)
  • Update omnibus-gitlab => omnibus-gitlab!2563 (merged)

What are the relevant issue numbers?

/cc @ayufan @nick.thomas @yorickpeterse

Edited by Kamil Trzciński

Merge request reports