Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar

Scheduled maintenance on the database layer will take place on 2022-07-02. We expect GitLab.com to be unavailable for up to 2 hours starting from 06:00 UTC. Kindly follow our status page for updates and read more in our blog post.

  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !18624

Fix file_store for artifacts and lfs when saving

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Kamil Trzciński requested to merge make-job-lfs-artifacts-read-only into master Apr 27, 2018
  • Overview 12
  • Commits 1
  • Pipelines 7
  • Changes 8

What does this MR do?

This makes file_store to be updated only when file is changed, this prevents race conditions from happening during file migrations. This also makes LFS to not save LfsObject on every link to project which results in creating this race condition in the first place.

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by Backend
  • Conform by the merge request performance guides
  • Conform by the style guides

What are the relevant issue numbers?

https://gitlab.com/gitlab-com/infrastructure/issues/4115

Edited May 01, 2018 by Kamil Trzciński
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: make-job-lfs-artifacts-read-only