Skip to content

Skip `authenticate_user!` for Doorkeeper controllers

Bob Van Landuyt requested to merge bvl-fix-openid-redirect into master

What does this MR do?

This just adds the required methods to the Doorkeeper::ApplicationController by adding a new Gitlab::DoorkeeperBaseController instead of having ApplicationController and having to deal with authentication.

We needed to make sure FastGettext is initialized before any controllers, so I moved that initializer to avoid errors like:

/Users/bvl/.rbenv/versions/2.3.7/lib/ruby/gems/2.3.0/gems/fast_gettext-1.6.0/lib/fast_gettext/storage.rb:79:in `current_repository': Current textdomain (nil) was not added, use FastGettext.add_text_domain ! (FastGettext::Storage::NoTextDomainConfigured)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/44639

Edited by Bob Van Landuyt

Merge request reports