Skip to content

[Rails5] Avoid type casting in uniqueness validator

What does this MR do?

This MR does two things:

  1. Synchronizes Gemfile.rails5.lock with the latest changes in Gemfile.
  2. Adds a monkey patch for active record to avoid type casting in uniqueness validator.

In Rails 5.0 there was introduced a bug that causes to problems like this:

1) API::Users POST /user/:id/gpg_keys/:key_id/revoke when authenticated revokes existing key
Failure/Error: let(:gpg_key) { create(:gpg_key, user: user) }
TypeError:
  can't cast Hash

This bug was fixed in Rails 5.1.

Are there points in the code the reviewer needs to double check?

No.

Why was this MR needed?

Migration to Rails 5.0.

Screenshots (if relevant)

No.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

#14286 (closed) and !12841 (closed)

Merge request reports

Loading