Changes the ID for the performance bar to correctly sticky the stat bar to the top (!18359) · Merge requests · GitLab.org / GitLab FOSS · GitLab

Snippets Groups Projects

You need to sign in or sign up before continuing.

Merged Phil Hughes requested to merge changes-bar-peek-id-change into master 6 years ago

What does this MR do?

Updates the ID of the performance bar from peek to js-peek so that it correctly adds the offset to the changes bar when sticking to the top of the browser.

Activity

Phil Hughes assigned to @filipa 6 years ago

assigned to @filipa
Filipa Lacerda approved this merge request 6 years ago

approved this merge request
Filipa Lacerda @filipa 6 years ago

Contributor

Thanks @iamphill ! LGTM

Edited 6 years ago by Filipa Lacerda
Filipa Lacerda @filipa 6 years ago

Contributor

Failures are unrelated
Filipa Lacerda merged 6 years ago

merged
Filipa Lacerda mentioned in commit 59707ade 6 years ago

mentioned in commit 59707ade
Filipa Lacerda @filipa 6 years ago

Contributor

Picked into https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/18500, will merge into 10-7-stable ready for 10.7.1
Filipa Lacerda mentioned in commit 4b0547eb 6 years ago

mentioned in commit 4b0547eb

Please register or sign in to reply