Skip to content

Add all filter to /admin/users

George Tsiolis requested to merge gtsiolis/gitlab-foss:add-all-filter-to-admin-users into master

What does this MR do?

Adds an All filter to /admin/users.

Are there points in the code the reviewer needs to double check?

  1. Check if this is the most efficient way to query all users in the database or if we need another scope in https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/models/user.rb#L228
  2. Also, keep in mind that the search form above searches only against active users, but maybe this is irrelevant to this MR.

Screenshots

Before After
users-before users-after

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
    • Has been reviewed by Backend
    • Has been reviewed by Database

What are the relevant issue numbers?

Closes #30603 (moved)

Edited by George Tsiolis

Merge request reports