Skip to content

[Rails5] Isolate `test_after_commit` gem

blackst0ne requested to merge blackst0ne-rails5-isolate-test_after_commit into master

What does this MR do?

  1. Adds unless condition for test_after_commit gem to the Gemfile. This gem has been integrated into rails 5.0. So it mustn't be included explicitly.
  2. Update Gemfile.rails5.lock with the latest gem updates from the current rails4 GitLab repository by BUNDLE_GEMFILE=Gemfile.rails5 bundle update -j$(nproc) rugged loofah.

Are there points in the code the reviewer needs to double check?

No.

Why was this MR needed?

Migration to Rails 5.0

Screenshots (if relevant)

No.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

#14286 (closed) and !12841 (closed)

Edited by blackst0ne

Merge request reports