Skip to content

Update rubocop to 0.54.0 to get rid of a warning in other MR

Lin Jen-Shin requested to merge update-rubocop into master

What does this MR do?

Update rubocop to get rid of a warning in other MR

Are there points in the code the reviewer needs to double check?

Most significant changes were coming from:

  • Rails/ActiveRecordAliases
  • Naming/UncommunicativeMethodParamName, we disallow single letter parameters

Changes: https://github.com/bbatsov/rubocop/compare/v0.52.1...v0.54.0

Why was this MR needed?

Get rid of a warning in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/17882

Parser::Source::Rewriter is deprecated.
Please update your code to use Parser::Source::TreeRewriter instead

Does this MR meet the acceptance criteria?

  • Tests added for this feature/bug
  • Review
    • Has been reviewed by Backend

Related Issues

Related: https://gitlab.com/gitlab-org/gitlab-ce/issues/46375

Edited by Gabriel Mazetto

Merge request reports