Skip to content

MR unmergeable notification

Mark Chao requested to merge lulalala/gitlab-ce:mr-conflict-notification into master

What does this MR do?

  • Notify MR author and merge user when MR became unmergeable.
  • Todo: create TODO for MR author and merge user when MR became unmergeable
  • User should not receive notification if his/her notifications are disabled for the project.

Are there points in the code the reviewer needs to double check?

As this is a new type of notification, a new type of NotificationRecipientService is added. Please see if this is okay.

Why was this MR needed?

To let MR author know about conflicts early.

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

#22041 (closed)

ping @smcgivern

Edited by Mark Chao

Merge request reports