Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !17965

Resolve "Autolinking includes trailing exclamation marks"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Sean McGivern requested to merge 44587-autolinking-includes-trailing-exclamation-marks into master Mar 23, 2018
  • Overview 4
  • Commits 1
  • Pipelines 2
  • Changes 3

What does this MR do?

Makes our new Rinku-less autolinking match the previous behaviour in https://github.com/vmg/rinku/blob/v2.0.1/ext/rinku/autolink.c#L65

Are there points in the code the reviewer needs to double check?

Don't think so!

Why was this MR needed?

The refactor in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/17180 introduced a regression.

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by Backend

What are the relevant issue numbers?

Closes #44587 (closed).

Edited Mar 23, 2018 by Sean McGivern
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 44587-autolinking-includes-trailing-exclamation-marks