Skip to content

Deleting a MR you are assigned to should decrements counter

m b requested to merge wayward_wanderer/gitlab-ce:ui-mr-counter-cache into master

What does this MR do?

it adds a call to User.update_cache_counts in the Issuable::DestroyService (if an assignee exists) so that the UI updates the summary of merge requests counts immediately (instead of waiting on the 20min cache expiration)

Are there points in the code the reviewer needs to double check?

whether or not the cache busting can be done inline, or needs to be wrapped in a Service object (I saw that pattern in the code, but wasn't sure if it applied here)

Why was this MR needed?

To fix a bug report

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Edited by m b

Merge request reports