Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab FOSS
GitLab FOSS
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Packages
    • Packages
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issues
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge Requests
  • !17867

Merged
Opened Mar 19, 2018 by Alexis Reigel@koffeinfrei6 of 13 tasks completed6/13 tasks
  • Report abuse
Report abuse

Display and revoke active sessions

  • Overview 110
  • Commits 29
  • Pipelines 18
  • Changes 23

What does this MR do?

Adds an active sessions menu entry to the profile settings page. That page shows all the user's active sessions (aka logged in devices).

The user may revoke any unknown sessions.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

From a security standpoint it's relevant to be able to identify active sessions and revoke any of it.

The development of this MR is sponsored by @ siemens (/cc @bufferoverflow).

Screenshots (if relevant)

image

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
    • Has been reviewed by Backend
    • Has been reviewed by Database
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
  • Internationalization required/considered
  • End-to-end tests pass (package-and-qa manual pipeline job)

What are the relevant issue numbers?

Edited May 02, 2018 by Douwe Maan

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch "https://gitlab.com/siemens/gitlab-ce.git" "feature/display-active-sessions"
git checkout -b "siemens/gitlab-ce-feature/display-active-sessions" FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "siemens/gitlab-ce-feature/display-active-sessions"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Assignee
Assign to
10.8
Milestone
10.8
Assign milestone
Time tracking
5
Labels
Community contribution admin dashboard authentication backend frontend
Assign labels
  • View project labels
Reference: gitlab-org/gitlab-foss!17867

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.