Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !17685

Fix code and wiki search results when filename is non-ASCII

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Sean McGivern requested to merge fix-code-search-500-with-non-ascii-filename into master Mar 12, 2018
  • Overview 5
  • Commits 1
  • Pipelines 1
  • Changes 3

What does this MR do?

Fixes this search: https://gitlab.com/search?utf8=%E2%9C%93&search=webhook&group_id=&project_id=72724&search_code=true&repository_ref=master

Once this is deployed to staging, this should work: https://staging.gitlab.com/search?utf8=%E2%9C%93&search=webhook&group_id=&project_id=72724&search_code=true&repository_ref=master

Are there points in the code the reviewer needs to double check?

Did I miss any other potential non-ASCII data?

Why was this MR needed?

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/17413#note_62580006

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by Backend
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-code-search-500-with-non-ascii-filename