Skip to content

Resolve "Some dropdowns have two scroll bars."

Dennis Tang requested to merge 43273-fix-double-scrollbar-dropdowns into master

What does this MR do?

Adjusts specific max-height CSS rules to correspond to the new max-height of dropdowns of 312px.

Are there points in the code the reviewer needs to double check?

No, but I did try to use flexbox to not have to continue to adjust max-heights if the spec for the dropdown changes, but it falls apart in IE11 since we need a height set for any elements that have min-height set, which defeats the purpose of having a dropdown with dynamic height... 😢

Why was this MR needed?

Because of a recent change to adjust the max height for all dropdowns to be 312px.

Screenshots (if relevant)

Before Bildschirmfoto_2018-03-09_um_14.19.47

After Bildschirmfoto_2018-03-09_um_14.16.01

One thing to note, is that the new height for dropdowns makes the dropdown for the Boards feature show only two options at a time, which doesn't seem optimal:

Bildschirmfoto_2018-03-09_um_15.23.08

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes #43273 (closed)

Edited by Dennis Tang

Merge request reports