Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !17286

Resolve "Display IP Address Of Runner On Runner Page"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dylan Griffith requested to merge 43489-display-runner-ip into master Feb 22, 2018
  • Overview 31
  • Commits 5
  • Pipelines 10
  • Changes 11

What does this MR do?

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Screenshots (if relevant)

Admin Form

Before

Screen_Shot_2018-02-26_at_2.29.08_pm

After

Screen_Shot_2018-02-26_at_2.30.43_pm

Admin Runners Table

Before

Screen_Shot_2018-02-26_at_2.33.28_pm

After

Screen_Shot_2018-02-26_at_2.34.23_pm

Project Runner Show Page

Before

Screen_Shot_2018-02-26_at_2.39.49_pm

After

Screen_Shot_2018-02-26_at_2.40.02_pm

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • [-] Documentation created/updated
  • [-] API support added
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
    • Has been reviewed by Backend
    • Has been reviewed by Database
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
  • Internationalization required/considered
  • End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

Closes #43489 (closed)

Edited Feb 28, 2018 by Kamil Trzciński
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 43489-display-runner-ip