Skip to content

GitLab Next

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • GitLab FOSS GitLab FOSS
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLab FOSSGitLab FOSS
  • Merge requests
  • !17206
The source project of this merge request has been removed.

Resolve "Pages Domain API returns 404 when using a specific domain"

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Travis Miller requested to merge travismiller/gitlab-ce.1:40668-pages-domain-api-returns-404-when-using-a-specific-domain into master Feb 19, 2018
  • Overview 1
  • Commits 1
  • Changes 3

What does this MR do?

Fixes issue where retrieving a single pages domain does not work when accessing endpoint by path and project name includes a period.

$ curl --header "PRIVATE-TOKEN: 9koXpg98eAheJpvBs5tK" https://gitlab.example.com/api/v4/projects/namespace%2Fmy.project/pages/domains/www.domain.example

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

Common case might be a project that is named with a domain name. See issue #40668 (closed)

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated
  • API support added
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
    • Has been reviewed by Backend
    • Has been reviewed by Database
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
  • Internationalization required/considered
  • End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

Closes #40668 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 40668-pages-domain-api-returns-404-when-using-a-specific-domain